develooper Front page | perl.perl5.porters | Postings from November 2016

[perl #130149] [PATCH] Make (P)ure funcs in embed.fnc imply that(R)eturn value must be checked

Thread Next
From:
Karl Williamson via RT
Date:
November 23, 2016 16:54
Subject:
[perl #130149] [PATCH] Make (P)ure funcs in embed.fnc imply that(R)eturn value must be checked
Message ID:
rt-4.0.24-4476-1479920079-1031.130149-15-0@perl.org
Inspired by this commit, I made the following commit to blead:

commit a62e8919a5bc84aae5f5c90173723bf81f449644
 Author: Karl Williamson <khw@cpan.org>
 Date:   Tue Nov 22 11:30:28 2016 -0700
 
     embed.fnc: Remove inappropriate pure attributes
     
     In looking at the diffs from f6e4c377437f9b2ded79fb55f66983a6d4f761f9,
     just committed, I realized that some of the functions marked pure,
     really have side effects, if only initialization if not called
     previously.  Still, the compiler could optimize things so it is wrong.
     I then did a manual audit of embed.fnc, and removed the pure attribute
     of the functions that I found that have some potential side effects.

-- 
Karl Williamson

---
via perlbug:  queue: perl5 status: pending release
https://rt.perl.org/Ticket/Display.html?id=130149

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About