develooper Front page | perl.perl5.porters | Postings from November 2016

Re: Tabs and spaces in patches

Thread Previous
From:
Karl Williamson
Date:
November 11, 2016 16:32
Subject:
Re: Tabs and spaces in patches
Message ID:
ae8ef9c5-2f4b-ba27-c81f-65ad342de988@cpan.org


On 11/11/2016 05:15 PM, Eric Herman via perl5-porters wrote:
>
> On 11-11-16 16:46, Andy Lester wrote:
>
>> I’d also hope that a mass tabs-to-space conversion program would also
>> trim off trailing whitespace from each line.
>
> Can be done with sed, or perhaps it's a job for GNU Indent or similar? 
> If so, it may be useful to supply the indent params. Some other 
> projects do this:
>
> * https://github.com/torvalds/linux/blob/master/scripts/Lindent
>
> * https://github.com/dgryski/libchash/blob/master/Makefile#L75
>
>> We also need to be aware of code in the tree that is autogenerated with
>> tabs, like charclass_invlists.h.
>
> However, for the perl codebase, an indent script should almost 
> certainly not be mass-applied. Yet, if we could write one which 
> describes the "preferred" style, this alone would be useful for 
> guidance and could be referenced in the docs.
>

This all has been discussed before, and the decision was made that it 
would be a bad idea to do this globally, and that is why the current 
incremental approach was decided upon

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About