develooper Front page | perl.perl5.porters | Postings from November 2016

Re: Tabs and spaces in patches

Thread Previous | Thread Next
From:
demerphq
Date:
November 11, 2016 15:12
Subject:
Re: Tabs and spaces in patches
Message ID:
CANgJU+XXZjHwKYWLfzX09brmiyxBT2PnWSyiBEdAU=gGUVw1wg@mail.gmail.com
On 11 November 2016 at 15:56, Andy Lester <andy@petdance.com> wrote:
>
> On Nov 11, 2016, at 5:37 AM, Abigail <abigail@abigail.be> wrote:
>
> Is there an argument I shouldn't make a patch changing all leading
> tabs to spaces?
>
>
> Yes, because then “git annotate” will show that you have made the last edit
> on every line in the codebase.
>
> Tabs instead of spaces drive me nuts, too, but not enough that I want to add
> an otherwise-meaningless change to every line.

git-annotate is deprecated in favour of git-blame.

But both of them support the -w switch, which ignores whitespace only changes.

IMO this argument doesnt carry much weight now that we are on git. In
perforce git-blame did not have a -w option.

cheers,
Yves


-- 
perl -Mre=debug -e "/just|another|perl|hacker/"

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About