On 1 November 2016 at 17:42, <pali@cpan.org> wrote: > Hi Steve! > > Sorry, but I cannot reproduce 3. That test ext/XS-APItest/t/utf8.t > passes and even it does not use Encode... > > Can you provide steps to reproduce problem 3? Sorry, I hadn't realized, but this test is failing for me even without the Encode upgrade. So as far as Encode goes we should be good to go with a 2.08 release including the fixes for 1 and 2 that Dan already committed. > > Btw, how it is possible that you got compile failures? Encode 2.87 > passed all compile & unit tests on all perl versions 5.8 -- 5.24, see: > https://travis-ci.org/dankogai/p5-encode/builds/171292122 Presumably the compiler used by Travis isn't a picky one like MS Visual C++ (which I use), which doesn't allow code before declarations (C89-style). > > On Tuesday 01 November 2016 14:35:38 Dan Kogai wrote: >> First two are fixed in: >> >> https://github.com/dankogai/p5-encode/commit/d14cc64e5ecf9056f55e6a96 >> 71984c3b988f14c6 >> >> The last one I need to defragment my schedule a little. PALI? >> >> Dan >> >> > On 2016 Nov 1, at 19:47, Steve Hay via perl5-porters >> > <perl5-porters@perl.org> wrote: >> > >> > On 28 October 2016 at 06:21, Dan Kogai <dankogai@dan.co.jp> wrote: >> > > Porters, >> > > >> > > Just VERSION++’ed so Encode. Many XS fixes by PALI. >> > >> > Thanks. I tried upgrading blead, but ran into three problems: >> > >> > 1. C89 compiler failures (patch attached). >> > >> > 2. encoding.pm has changed slightly but has no $VERSION++, which >> > will cause t/porting/cmp_version.t to fail. >> > >> > 3. ext/XS-APItest/t/utf8.t fails 7140 tests! :-( Are you able to >> > look into this? >> > >> > <C89.patch>Thread Previous | Thread Next