develooper Front page | perl.perl5.porters | Postings from October 2016

Re: [perl #129954] dist/Carp/t/arg_string.t: Test fails in blead

Thread Previous
From:
Dave Mitchell
Date:
October 27, 2016 10:21
Subject:
Re: [perl #129954] dist/Carp/t/arg_string.t: Test fails in blead
Message ID:
20161027102054.GU3128@iabyn.com
On Thu, Oct 27, 2016 at 09:19:02AM +0100, Dave Mitchell wrote:
> I think the test was being overly picky.
> 
> I've just pushed the following:

And that was being underly picky, so I just pushed the following too:

commit fd609c8d943a834b7d5da7251eb47c05d7f8f9fc
Author:     David Mitchell <davem@iabyn.com>
AuthorDate: Thu Oct 27 09:29:33 2016 +0100
Commit:     David Mitchell <davem@iabyn.com>
CommitDate: Thu Oct 27 09:32:48 2016 +0100

    Carp/t/arg_string.t: fixup to previous fixup
    
    I added alternates to a regex for matching a f/p number, but forgot
    to put parentheses around them. So it was being ridiculously over-liberal


Affected files ...
    M	dist/Carp/t/arg_string.t

Differences ...

diff --git a/dist/Carp/t/arg_string.t b/dist/Carp/t/arg_string.t
index 4c754c5..dc70f43 100644
--- a/dist/Carp/t/arg_string.t
+++ b/dist/Carp/t/arg_string.t
@@ -26,9 +26,11 @@ like lm(-3), qr/main::lm\(-3\)/;
 like lm(-3.5), qr/main::lm\(-3\.5\)/;
 like lm(-3.5e30),
             qr/main::lm\(
+              (
                 -3500000000000000000000000000000
-              | -3\.5[eE]\+?0?30\)
-            /x;
+              | -3\.5[eE]\+?0?30
+              )
+              \) /x;
 like lm(""), qr/main::lm\(""\)/;
 like lm("foo"), qr/main::lm\("foo"\)/;
 like lm("a\$b\@c\\d\"e"), qr/main::lm\("a\\\$b\\\@c\\\\d\\\"e"\)/;


-- 
All wight. I will give you one more chance. This time, I want to hear
no Wubens. No Weginalds. No Wudolf the wed-nosed weindeers.
    -- Life of Brian

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About