develooper Front page | perl.perl5.porters | Postings from October 2016

Re: hv.h hek definition

Thread Previous | Thread Next
Todd Rinaldo
October 25, 2016 15:15
Re: hv.h hek definition
Message ID:

> On Oct 22, 2016, at 4:15 AM, demerphq <> wrote:
>> This patch seems to pass tests. It seems too simple, but then that's the beauty of using macros, right?
> Personally I think the patch is probably safe with the assert added
> that bulk88 mentioned, but I kinda wonder why it wasn't done that way
> in the first place, and would want to dig a bit to see why not before
> I applied it. On the other hand I like the idea of applying it, it
> definitely is simpler code.

I did some digging of my own when I developed this patch. I had to go past a commit barrier where Nick Clark made the code significantly more legible by introducing macros for all of this. As best I can tell, the flag was off the end even way back when the hek was more analgous to a PV. I suspect they threw it on the end as an after thought to reduce the required coding to add the flags. IMO there wasn't a good reason though I'd probably have to sift through Read News to be sure of it.


Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About