develooper Front page | perl.perl5.porters | Postings from October 2016

Re: [perl #129229] [PATCH] Fix Parallel Building

Thread Previous | Thread Next
From:
demerphq
Date:
October 24, 2016 16:14
Subject:
Re: [perl #129229] [PATCH] Fix Parallel Building
Message ID:
CANgJU+UtDg-SDNiXx_SmHEYC0_S=xQ3fXb5OZ77jariwwUDDRA@mail.gmail.com
On 24 October 2016 at 17:57, demerphq <demerphq@gmail.com> wrote:
> On 24 October 2016 at 17:42, demerphq <demerphq@gmail.com> wrote:
>> On 24 October 2016 at 17:35, Tom Hukins <tom@eborcom.com> wrote:
>>> On Mon, Oct 24, 2016 at 08:24:54AM -0700, James E Keenan via RT wrote:
>>>> I'm attaching a different instance of what I suspect is the same kind
>>>> of build failure
>>>
>>> Yes, this looks like the same problem to me.
>>>
>>>> --- MANIFEST.srt ---
>>>> Can't locate Cwd.pm in @INC (you may need to install the Cwd module) (@INC contains: lib /usr/local/lib/perl5/site_perl/5.25.7/amd64-freebsd-thread-multi /usr/local/lib/perl5/site_perl/5.25.7 /usr/local/lib/perl5/5.25.7/amd64-freebsd-thread-multi /usr/local/lib/perl5/5.25.7 .) at lib/File/Find.pm line 8.
>>>> Compilation failed in require at Porting/pod_lib.pl line 4.
>>>> BEGIN failed--compilation aborted at Porting/pod_lib.pl line 4.
>>>> Compilation failed in require at Porting/manisort line 17.
>>>> WARNING: re-sorting MANIFEST
>>>
>>> The MANIFEST.srt make target fails to find Cwd.pm.  The original patch I
>>> sent for this ticket made the MANIFEST.srt target depend on the presence
>>> of this file.
>>
>> I will merge James' patch in a few minutes if it passes test. Which
>> should fix this. We need introduce no dependencies with this feature.
>
> So I have done this.

To dispel some confusion: I merged the following:

commit 4a59181454f23dbf43f396b924ff7434b63c9d98
Author: Aaron Crane <arc@cpan.org>
Date:   Wed Oct 12 10:34:13 2016 +0100

    RT#129229: move sort_manifest() into its own library

    This means that the MANIFEST.srt target in the Makefile no longer needs
    to load a library that depends on Cwd (and other potentially-dynamic
    modules). That in turn fixes a missing-dependency bug in the Makefile.




-- 
perl -Mre=debug -e "/just|another|perl|hacker/"

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About