develooper Front page | perl.perl5.porters | Postings from September 2016

[perl #116775] Broken test t/op/groups.t

Thread Next
From:
James E Keenan via RT
Date:
September 30, 2016 19:37
Subject:
[perl #116775] Broken test t/op/groups.t
Message ID:
rt-4.0.24-26509-1475264240-1183.116775-15-0@perl.org
On Fri Sep 30 07:42:21 2016, dcollinsn@gmail.com wrote:
> On Fri Jul 12 18:24:55 2013, jkeenan wrote:
> > On Sun Feb 17 15:42:59 2013, jbenjore wrote:
> > > It is possible that on Darwin perl's $( should call the libc
> > > function
> > > getgrouplist(3) *instead* of getgroups(2). The libc function
> > > consults
> > > Open Directory and is not limited by the kernel's NGROUPS_MAX
> > > allocation.
> > >
> > > Further, it is just a rank stupid bug that this code can run and
> > > omit at
> > > least a "not ok 1". Apologies for
> > > http://perl5.git.perl.org/perl.git/blob/651d4685ebdde5512841551572b29e74
> > > 605bfc38:/t/op/groups.t#l120 which clearly allows for a missing
> > > "not ok
> > > 1".
> 
> The suggestion to enhance the test in the first quoted paragraph
> aside, the present bug is that a failing test here looks like "tests
> out of sequence" and "bad plan" instead of "FAILED". The attached
> patch will correct that issue.

#####
 unless ( $ok1 ) { 
- 
+ print "nok 1 (perl's `\$(' disagrees with `${groups_command}'\n"; } }
#####

I generally don't like the use of the backtick character (`) to mean "single open quotation mark".  But since that style is already established in the error messages in t/op/groups.t ... +1.

Thank you very much.

-- 
James E Keenan (jkeenan@cpan.org)

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=116775

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About