Re: clang -Weverything

> On Jul 30, 2016, at 8:36 AM, Jarkko Hietaniemi <jhi@iki.fi> wrote:
> 
> clang has -Weverything which is what one might imagine gcc -Wall
> would mean, but doesn't.
> 
> Patch attached, but NOT to be applied immediately, works on top of
> http://perl5.git.perl.org/perl.git/commitdiff/863ca36a1db803bdd82e88ef0e862696379ba681
> 
> Why not to be applied immediately?
> 
> Well, the blead is not -Weverything-clean.


Not even close, but I'm taking a stab at it.  Part of it is figuring out which warnings we need to explicitly ignore so that we keep just the stuff we care about.

I've started a branch at https://github.com/petdance/perl5/tree/Weverything and so far the biggies that I think it's safe to knock out are:

        # -Wno-unused-macros: We have tons of macros and it's OK if we don't use them.
        # -Wno-gnu-statement-expression: Commonly used all over the codebase.
        # -Wno-shadow: We have many common global variable names.  We would have to change many local variables.
        # -Wno-overlength-strings: Compiler limit we don't care about
        # -Wno-disabled-macro-expansion
        # -Wno-variadic-macros: We use them.
        # -Wno-cast-align
        # -Wno-extended-offsetof
        # -Wno-c11-extensions

Beyond that, I'm not sure what we're OK with handwaving away.  Thoughts?

--
Andy Lester => www.petdance.com

• clang -Weverything by Jarkko Hietaniemi
• Re: clang -Weverything by Andy Lester
• Re: clang -Weverything by Andy Lester
• Re: clang -Weverything by Sawyer X