develooper Front page | perl.perl5.porters | Postings from September 2016

Re: [perl #129229] [PATCH] Fix Parallel Building

Thread Previous | Thread Next
Dan Collins
September 20, 2016 13:50
Re: [perl #129229] [PATCH] Fix Parallel Building
Message ID:
If MANIFEST is procedurally generated, is there such a thing as a
pre-commit hook, either on the client side (for every commit) or on the
server side (for pushing to blead/maint-5.*) that would prompt a committer
to run manisort, or do so automatically, if necessary? That might help
prevent the "MANIFEST is not sorted" situation to begin with.

Dan Collins

On Tue, Sep 20, 2016 at 8:59 AM, Father Chrysostomos via RT <> wrote:

> On Tue Sep 20 05:07:29 2016, davem wrote:
> > How about we just don't bother keeping MANIFEST strictly sorted during
> > development, (and so don't automatically test it for sortedness), and
> > instead have it as an extra manual step in the release process ("step
> > 97:
> > run 'make manisort' and commit if MANIFEST has changed"). So it just
> > gets
> > done once per month and doesn't get in the way of everyone else.
> That makes sense.  I was thinking of proposing that next if anyone
> objected to a simple revert of the change.  I have been wondering since I
> started hacking on perl why we needed to keep it sorted anyway.
> The best way to solve something that shouldn’t be a problem to begin with
> is to remove the problem instead of working around it.
> > That does however leave open the issue of whether we should still
> > automatically check for correctness (i.e. that MANFEST == git ls-
> > files).
> manifest.t should continue to perform its other tests.
> --
> Father Chrysostomos
> ---
> via perlbug:  queue: perl5 status: open

Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About