Front page | perl.perl5.porters |
Postings from September 2016
On Tue, Sep 20, 2016 at 10:59:42PM +1200, Kent Fredric wrote:
> On 20 September 2016 at 19:43, Father Chrysostomos via RT
> <perlbug-followup@perl.org> wrote:
> > The problem with automatically sorting the MANIFEST is what I mentioned above: ‘make’ should not make changes to files tracked by git. I think that commit was ill-advised.
>
> Before that commit, the patching the manifest causes a handful of
> porting tests to fail *every* time, instead of only failing due to
> Cwd.pm 10% of the time.
>
> And given we're patching, compiling, testing, and then installing on
> the users machine ( Gentoo ), failing simply because the manifest
> isn't sorted is not great for the deployment side of the equation.
>
> But I'll have to see if the fix works ( hard to know for sure because
> 10% is low enough you could do dozens of builds without one failing ).
>
> I suspect it will, because I'd have suggested a similar patch.
How about we just don't bother keeping MANIFEST strictly sorted during
development, (and so don't automatically test it for sortedness), and
instead have it as an extra manual step in the release process ("step 97:
run 'make manisort' and commit if MANIFEST has changed"). So it just gets
done once per month and doesn't get in the way of everyone else.
That does however leave open the issue of whether we should still
automatically check for correctness (i.e. that MANFEST == git ls-files).
--
Wesley Crusher gets beaten up by his classmates for being a smarmy git,
and consequently has a go at making some friends of his own age for a
change.
-- Things That Never Happen in "Star Trek" #18
Thread Previous
|
Thread Next