develooper Front page | perl.perl5.porters | Postings from September 2016

Re: [perl #129229] [PATCH] Fix Parallel Building

Thread Previous | Thread Next
From:
Kent Fredric
Date:
September 20, 2016 10:59
Subject:
Re: [perl #129229] [PATCH] Fix Parallel Building
Message ID:
CAATnKFDQRPtBe2R-37YA-T+dZXACbe+==60Szy_Y-WL6JRCCKQ@mail.gmail.com
On 20 September 2016 at 19:43, Father Chrysostomos via RT
<perlbug-followup@perl.org> wrote:
> The problem with automatically sorting the MANIFEST is what I mentioned above: ‘make’ should not make changes to files tracked by git.  I think that commit was ill-advised.

Before that commit, the patching the manifest causes a handful of
porting tests to fail *every* time, instead of only failing due to
Cwd.pm 10% of the time.

And given we're patching, compiling, testing, and then installing on
the users machine ( Gentoo ), failing simply because the manifest
isn't sorted is not great for the deployment side of the equation.

But I'll have to see if the fix works ( hard to know for sure because
10% is low enough you could do dozens of builds without one failing ).

I suspect it will, because I'd have suggested a similar patch.

-- 
Kent

KENTNL - https://metacpan.org/author/KENTNL

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About