[perl #129229] [PATCH] Fix Parallel Building

Front page | perl.perl5.porters | Postings from September 2016

[perl #129229] [PATCH] Fix Parallel Building

Thread Previous | Thread Next

From:

Father Chrysostomos via RT

Date:

September 20, 2016 07:43

Subject:

[perl #129229] [PATCH] Fix Parallel Building

Message ID:

rt-4.0.24-16642-1474357417-554.129229-15-0@perl.org

On Tue Sep 20 00:40:13 2016, sprout wrote:
> On Tue Sep 20 00:36:46 2016, sprout wrote:
> > What I want to know is why the build is trying to sort MANIFEST at
> > all.  Ideally, ‘make’ should *never* touch checked-in files, because
> > then ‘make distclean’ doesn’t work.  You can’t get a clean slate
> > unless you are using a git repository.
> 
> Does the attached diff also fix the problem?  (Instead of working
> around the problem, it removes the cause.)

Digging a little further, I see this commit:

commit 19bf1007743b4337230ad3a4538df4bd94311fc4
Author: Yves Orton <demerphq@gmail.com>
Date:   Thu Dec 25 15:44:14 2014 +0100

    automatically sort the MANIFEST if necessary
    
    Instead of harrasing people to sort the manifest in our
    tests, we can just automatically sort the manifest when it
    changes.
    
    That way the tests are actually testing that the auto-sort
    worked, and not that our devs put the new file in the right
    place.

The problem with automatically sorting the MANIFEST is what I mentioned above: ‘make’ should not make changes to files tracked by git.  I think that commit was ill-advised.

-- 

Father Chrysostomos


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=129229

Thread Previous | Thread Next