develooper Front page | perl.perl5.porters | Postings from September 2016

Re: [perl #129176] Conditional jump depends on uninitialized valuesin S_scan_heredoc

Thread Previous | Thread Next
From:
Dave Mitchell
Date:
September 7, 2016 20:45
Subject:
Re: [perl #129176] Conditional jump depends on uninitialized valuesin S_scan_heredoc
Message ID:
20160907204517.GF3173@iabyn.com
On Tue, Sep 06, 2016 at 08:37:46AM +0100, Dave Mitchell wrote:
> On Mon, Sep 05, 2016 at 09:36:54AM -0700, Father Chrysostomos via RT wrote:
> > On Mon Sep 05 07:45:59 2016, davem wrote:
> > > On Mon, Sep 05, 2016 at 06:41:12AM -0700, Father Chrysostomos via RT wrote:
> > > > On Mon Sep 05 06:13:44 2016, davem wrote:
> > > > > On Fri, Sep 02, 2016 at 10:31:37PM -0700, Father Chrysostomos via RT
> > > > It doesn’t conflict with ba0a4150f6f, does it?
> > > 
> > > Almost certainly :-)
> > > I'll work round it.
> > 
> > Let me guess, it’s probably something like:
> > 
> > -       if (allow_escape && *from == '\\') {
> > +       if (allow_escape && from+1 < fromend *from == '\\') {
> 
> might be ;-)
> 
> (plus tests of course)

Now fixed with 19e1655416b3c03817d6123958721515e146fc9f.

I took the liberty of also doing this:

    commit 31ee10f11cbfafd3c6f5bfdeef5f0215f75a2833
    Author:     David Mitchell <davem@iabyn.com>
    AuthorDate: Wed Sep 7 20:57:01 2016 +0100

    rename S_delimcpy() to S_delimcpy_intern()
    
    Its a bit confusing having both S_delimcpy() and Perl_delimcpy()
    functions.




-- 
You're only as old as you look.

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About