Front page | perl.perl5.porters |
Postings from September 2016
On Sun, Sep 04, 2016 at 09:30:44PM -0700, Father Chrysostomos via RT wrote:
> On Sun Sep 04 19:19:45 2016, jkeenan wrote:
> > On Sun Sep 04 18:28:05 2016, jkeenan wrote:
> > > On Sun Sep 04 13:13:07 2016, dcollinsn@gmail.com wrote:
> > > > To be clear, James, this is after applying Father C's patch? Can
> > > > you
> > > > provide the output of `valgrind ./perl t/op/evalbytes.t`?
> > > >
> > >
> > > Hmm, the fact that he didn't save that patch with the sort of name
> > > which 'git format-patch' would apply led me to overlook it.
> > >
> > > Checking now.
> >
> > Okay, now having actually applied the patch in branches on each OS, I
> > am getting PASS for 'make test_harness' and for the t/op/evalbytes.t
> > by itself.
> >
> > Thank you very much.
>
> Thank you for testing. I have applied both patches, as 9bde56224 and a612871 respectively.
Around the time this commit was pushed, win32 smokers and Jenkins have
been failing to compile, with
..\toke.c(7586) : error C2105: '--' needs l-value
However, your commit doesn't touch the affected area of code, which hasn't
changed since 2011:
7584: case KEY_evalbytes:
7585: PL_expect = XTERM;
7586: UNIBRACK(-OP_ENTEREVAL);
The error would seem to imply that OP_ENTEREVAL has been defined to a
negative value, but it's been 345 in opnames.h for a month now.
So I can't see what the problem is.
--
Counsellor Troi states something other than the blindingly obvious.
-- Things That Never Happen in "Star Trek" #16
Thread Previous
|
Thread Next