develooper Front page | perl.perl5.porters | Postings from September 2016

[perl #128856] DirHandle: Improve test coverage and providedescriptions

Thread Previous | Thread Next
From:
James E Keenan via RT
Date:
September 5, 2016 12:53
Subject:
[perl #128856] DirHandle: Improve test coverage and providedescriptions
Message ID:
rt-4.0.24-2854-1473080003-205.128856-15-0@perl.org
On Mon Sep 05 05:07:59 2016, tonyc wrote:
> On Tue Aug 30 09:22:45 2016, jkeenan wrote:
> > 
> > Tony C:  Ping re second patch.
> 
> There's some spelling errors in the test comments:
> 
> 
> + "Calling read method after failed open method returns faluse value"); 
>                                                          *****
> 
> repeated in 2 other places.
> 
> As to DESTROY, all you can really do to test it is to check for resource
> leaks, which is more in the domain of tools like valgrind.
> 
> Testing the return value of DESTROY doesn't really check that any resources
> have been released.
> 
> Tony

Please review replacement patch attached.

Thank you very much.
-- 
James E Keenan (jkeenan@cpan.org)

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=128856

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About