On 08/14/2016 11:12 PM, Aristotle Pagaltzis wrote: > * demerphq <demerphq@gmail.com> [2016-08-14 14:24]: >> I have pushed a patch series which moves the Hash::Util related stuff >> out of universal.c, and removes hv_clear_placeholders() from >> Internals. I am pretty sure this should not affect anything sane. > It seems to have about a dozen actual callers on CPAN: > http://grep.cpan.me/?q=-file%3Appport.h+hv_clear_placeholders > > It’s not a big effort to send patches for those, but there is enough use > that I assume there must be a small amount of use in the DarkPAN also, > and we can’t patch that. So this seems to call for a whiny placeholder > to get people to switch, which loads and calls Hash::Util for them in > the meantime (like FatherC’s approach with arybase). [I've read the rest of the thread, but I think this is a good place to pause and response.] Yves, thank you for the changes you committed. That's great! I agree that, while there really shouldn't have been those usages that Aristotle linked to, I was also wondering if they existed (and Aristotle is always a step ahead and already checked and provided the link) and I'm also worried about those breaking right away. In this case I do not think that we earn anything right away by moving them without giving any warning. It would courteous of us to warn before fully removing its old namespace. It costs us a little annoyance but it goes a long way to the developer. > Also I guess its deprecation warning should mention which version of > Hash::Util callers need to depend on when they switch, so people don’t > forget to ensure that they do. +1 Thank you, Yves and Aristotle! :)Thread Previous | Thread Next