[sorry about the lag on this reply, i came down with a nasty flu the day we were discussing this] On 10 August 2016 at 07:28, Father Chrysostomos <sprout@cpan.org> wrote: > > On Aug 8, 2016, at 6:24 AM, demerphq <demerphq gmail.com> wrote: > >> SvREFCNT() is used in testing, and arguably should not exist, and >> instead should be exposed via an extension, perhaps Devel::Peek, or >> perhaps some build time only module. > > Devel::Peek already has SvREFCNT. Which is all the better reason to migrate everything in core tests that use SvREFCNT to use the Devel::Peek version. :-) > >> I wonder, do you think we should document constant::_make_const()? >> >> IMO that function has far more call being documented than anything in >> the Internals namespace. > > Not as a public function, I hope. Nothing should be calling it except constant.pm. Also, how do you explain in a few words the effect of SvPADTMP on the array elements? If anything, that explanation should go in universal.c—as a C comment, not as pod. > I am not unsympathetic to this kind of argument. I just wonder why it doesnt apply to SvREFCNT and SvREADONLY. :-) Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"Thread Previous | Thread Next