develooper Front page | perl.perl5.porters | Postings from August 2016

Re: merging optimising sub signature work so far

Thread Previous | Thread Next
Dave Mitchell
August 9, 2016 21:11
Re: merging optimising sub signature work so far
Message ID:
On Mon, Aug 08, 2016 at 07:19:35PM +0100, Zefram wrote:
> Dave Mitchell wrote:
> >*  Moves the parsing of the signature (i.e. the '($a,$b=1,@c)' thing)
> >   from custom code in toke.c to normal yacc rules in perly.y;
> You've also removed the parse_subsignature() function, and that's
> a problem.  It was intended to be an API function, once signatures are
> no longer experimental.  It needs to be an API function in order to make
> it feasible for an XS module to parse the top-level "sub" syntax itself,
> which is needed as a base on which to create any syntactic variation of
> subroutine syntax.  It doesn't matter which way the actual parsing is
> done; just the interface needs to remain.

Well, the function parse_subsignature() wasn't marked as API, had no
documentation, had no tests, wasn't exported, and had no indication that
it was intended as part of a future API - so I feel no remorse for having
removed it. It is also not needed for perl itself to parse subroutine
signatures, so I feel no obligation to re-implement it right now. If at
some point someone wishes to submit a patch re-adding such a function,
then of course that should be considered on its merits.

I thought I was wrong once, but I was mistaken.

Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About