develooper Front page | perl.perl5.porters | Postings from August 2016

[perl #128598] Quadmath builds fail porting/libperl.t

Thread Previous
From:
Tony Cook via RT
Date:
August 9, 2016 20:42
Subject:
[perl #128598] Quadmath builds fail porting/libperl.t
Message ID:
rt-4.0.24-20272-1470724502-1060.128598-15-0@perl.org
On Thu Jul 14 19:58:13 2016, public@khwilliamson.com wrote:
> I believe we call some compilers on some platforms with just "-O".  I
> suspect that it's best to skip unless there is an explicit "-O0".

I believe the real problem is using strcat() at all, I suspect from this
comment:

+     * This is one of the few places in the perl core, where we can use
+     * standard functions like strlen() and strcat().  It's because we're
+     * looking for NULs. */

that you misunderstood why we avoid strcpy(), strcat().

We have my_strlcat() and my_strlcpy() that deal with NUL terminated strings
and are used throughout the perl core.

The attached replaces strcat() with my_strlcat() and removes the exception in
libperl.t

Tony

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=128598

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About