develooper Front page | perl.perl5.porters | Postings from July 2016

Re: [perl #128630] commit 15899733e changes SKIP to FAIL on Win32 inop/sprintf.t

Thread Previous | Thread Next
From:
Dan Collins
Date:
July 26, 2016 01:13
Subject:
Re: [perl #128630] commit 15899733e changes SKIP to FAIL on Win32 inop/sprintf.t
Message ID:
CA+tt54LQL-tz3WKpT=tsYCQAHPR1hDKpNGOc8KrP_Y+DQb7=ig@mail.gmail.com
Before, it used $^O instead of $archname. Come to think of it, that is also
probably fine - though I don't know if there are any unusual ways to build
perl on Win32 that might end up with a strange $^O...

W:\buildbot\windows1\win64-mingww64-4_9_3\build>.\perl -Ilib -MConfig -wle
"print $^O; print $Config{archname}"
MSWin32
MSWin32-x64-multi-thread

On Mon, Jul 25, 2016 at 8:54 PM, Jarkko Hietaniemi via RT <
perlbug-followup@perl.org> wrote:

> On Mon Jul 25 17:07:03 2016, dcollinsn@gmail.com wrote:
> > On Mon Jul 25 16:50:22 2016, bulk88 wrote:
> > > It wasn't fixed by 6151d433633f874a63f2a659b8bdaf400afacf4d
> >
> > I agree with bulk88. These lines handle the skip logic for plain
> > win32:
> >
> > 140                 # >comment skip: netbsd:vax-netbsd<
> > 141                 $skip = $cond eq $archname;
> > 142             }
> >
> > That test has a skip condition "MSWin32", but my windows perls have
> > archnames like "archname=MSWin32-x64-multi-thread". I suggest that any
> > fix regex match `$archname =~ /\b$cond\b/` or `$archname =~ /^$cond/`
> > rather than relying on string equality.
> >
> > Copying/assigning to Jarkko, as he committed 6151d43363
>
> Before tweaking any further I would like to understand how the mswin32
> case matched before the 15899733e.
>
>
>
>
>
> ---
> via perlbug:  queue: perl5 status: open
> https://rt.perl.org/Ticket/Display.html?id=128630
>

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About