develooper Front page | perl.perl5.porters | Postings from July 2016

[perl #128630] commit 15899733e changes SKIP to FAIL on Win32 inop/sprintf.t

Thread Previous | Thread Next
From:
Dan Collins via RT
Date:
July 26, 2016 00:07
Subject:
[perl #128630] commit 15899733e changes SKIP to FAIL on Win32 inop/sprintf.t
Message ID:
rt-4.0.18-19892-1469491623-1908.128630-15-0@perl.org
On Mon Jul 25 16:50:22 2016, bulk88 wrote:
> It wasn't fixed by 6151d433633f874a63f2a659b8bdaf400afacf4d

I agree with bulk88. These lines handle the skip logic for plain win32:

 140                 # >comment skip: netbsd:vax-netbsd<
 141                 $skip = $cond eq $archname;
 142             }

That test has a skip condition "MSWin32", but my windows perls have archnames like "archname=MSWin32-x64-multi-thread". I suggest that any fix regex match `$archname =~ /\b$cond\b/` or `$archname =~ /^$cond/` rather than relying on string equality.

Copying/assigning to Jarkko, as he committed 6151d43363

-- 
Respectfully,
Dan Collins

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=128630

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About