Front page | perl.perl5.porters |
Postings from July 2016
On 18 July 2016 at 17:00, Dave Mitchell <davem@iabyn.com> wrote:
> On Mon, Jul 18, 2016 at 05:01:21PM +0300, Sergey Aleynikov wrote:
>> Commit 73949fca082fe50bf47755c5ffa328259057ae36 has never actually
>> made it into the 5.22 branch.
>> Is it possible to cherry-pick it for the next maint release (while
>> they are), as it's currently the only
>> thing that prevents Coro from compiling on 5.22?
>
> Sign, Marc seems not to have included FC's 4-line patch that would
> have made Coro build on 5.22.0.
>
> But in any case, I agree that cherry-picking this commit would be good.
>
As discussed in the last onionsketch [1], we have agreement for
including this in the forthcoming 5.22.3. I wasn't able to verify that
it fixes the Coro (6.511) build for me [2], but I'll trust the words
of the others who have spoken here that it does indeed fix the build
on other OSes, so I've now gone ahead and cherry-picked it. My
apologies that this got missed from previous 5.22.x releases.
[1] http://irclog.perlgeek.de/onionsketch/2016-07-18
[2] With a default build of
5.22.3-RC1+73949fca082fe50bf47755c5ffa328259057ae36, I get this when
building:
Microsoft (R) Program Maintenance Utility Version 10.00.30319.01
Copyright (C) Microsoft Corporation. All rights reserved.
nmake -f Makefile all -nologo
cl -c -nologo -GF -W3 -O1 -MD -Zi -DNDEBUG -GL -DWIN32
-D_CONSOLE -DNO_STRICT -D_CRT_SECURE_NO_DEPRECATE
-D_CRT_NONSTDC_NO_DEPRECATE -DPERL_TEXTMODE_SCRIPTS
-DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -O1 -MD -Zi -DNDEBUG -GL
-DVERSION=\"6.511\" -DXS_VERSION=\"6.511\"
"-IC:\perl5223RC1plus\lib\CORE" -DCORO_FIBER -DCORO_STACKSIZE=16384
-DCORO_GUARDPAGES=4 -DCORO_JIT=1 State.c
State.c
c:\Program Files (x86)\Microsoft Visual Studio
10.0\VC\INCLUDE\malloc.h(236) : error C2065: 'my_perl' : undeclared
identifier
c:\Program Files (x86)\Microsoft Visual Studio
10.0\VC\INCLUDE\malloc.h(236) : error C2223: left of '->IMem' must
point to struct/union
c:\Program Files (x86)\Microsoft Visual Studio
10.0\VC\INCLUDE\malloc.h(236) : error C2065: 'my_perl' : undeclared
identifier
c:\Program Files (x86)\Microsoft Visual Studio
10.0\VC\INCLUDE\malloc.h(236) : error C2223: left of '->IMem' must
point to struct/union
c:\dev\temp\coro-6.511\coro\ecb.h(477) : warning C4244: 'function' :
conversion from 'uint64_t' to 'uint32_t', possible loss of data
c:\dev\temp\coro-6.511\coro\ecb.h(525) : warning C4244: 'function' :
conversion from 'uint64_t' to 'uint32_t', possible loss of data
c:\dev\temp\coro-6.511\coro\ecb.h(571) : warning C4244: 'function' :
conversion from 'uint64_t' to 'uint32_t', possible loss of data
State.xs(402) : error C2059: syntax error : 'type'
State.xs(412) : error C2059: syntax error : 'type'
State.xs(422) : error C2059: syntax error : 'type'
State.xs(719) : error C2275: 'U32' : illegal use of this type as an expression
c:\perl5223rc1plus\lib\core\handy.h(175) : see declaration of 'U32'
State.xs(719) : error C2146: syntax error : missing ';' before
identifier 'svany_in_head_set'
State.xs(719) : error C2065: 'svany_in_head_set' : undeclared identifier
State.xs(726) : error C2065: 'svany_in_head_set' : undeclared identifier
State.xs(729) : error C2065: 'svany_in_head_set' : undeclared identifier
c:\dev\temp\coro-6.511\coro\state.h(85) : warning C4133: '=' :
incompatible types - from 'AV *' to 'PADNAMELIST *'
c:\dev\temp\coro-6.511\coro\state.h(85) : warning C4133: '=' :
incompatible types - from 'PADNAMELIST *' to 'AV *'
State.xs(3387) : warning C4244: '=' : conversion from 'I32' to 'U16',
possible loss of data
State.xs(4029) : warning C4013: 'coro_get_sv' undefined; assuming
extern returning int
State.xs(4029) : warning C4047: '=' : 'SV *' differs in levels of
indirection from 'int'
State.xs(4030) : warning C4047: '=' : 'SV *' differs in levels of
indirection from 'int'
State.xs(4032) : warning C4047: '=' : 'SV *' differs in levels of
indirection from 'int'
State.xs(4033) : warning C4013: 'coro_get_av' undefined; assuming
extern returning int
State.xs(4033) : warning C4047: '=' : 'AV *' differs in levels of
indirection from 'int'
State.xs(4034) : warning C4047: '=' : 'AV *' differs in levels of
indirection from 'int'
State.xs(4035) : warning C4047: '=' : 'SV *' differs in levels of
indirection from 'int'
State.xs(4036) : warning C4047: '=' : 'SV *' differs in levels of
indirection from 'int'
State.xs(4053) : warning C4047: 'initializing' : 'SV *' differs in
levels of indirection from 'int'
State.xs(4461) : warning C4047: '=' : 'SV *' differs in levels of
indirection from 'int'
NMAKE : fatal error U1077: '"c:\Program Files (x86)\Microsoft Visual
Studio 10.0\VC\BIN\cl.EXE"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"c:\Program Files (x86)\Microsoft Visual
Studio 10.0\VC\BIN\nmake.EXE"' : return code '0x2'
Stop.