Front page | perl.perl5.porters |
Postings from July 2016
Re: New encoding branch
Thread Previous
|
Thread Next
From:
Father Chrysostomos
Date:
July 12, 2016 00:51
Subject:
Re: New encoding branch
Message ID:
20160712005143.7319.qmail@lists-nntp.develooper.com
ilmari wrote:
> The patch adds this to encoding::warnings:
>
> In addition, the L<warnings> pragma, which caused many of the
> problems, is no longer supported.
>
> Shouldn't that be «the L<encoding> pragma»?
Yes. Thank you for catching that.
> I also noticed that some places check for "$]" >= 5.025, while others
> check for $] >= 5.025003. Is this discrepancy intentional?
The result of taking 5 weeks to do this. :-)
> The test in op/concat2.t can just go, since it's meant to test the
> behaviour of concat under 'encoding', which no longer exists.
Done. I have pushed a new branch.
Thank you for your review.
Thread Previous
|
Thread Next