Front page | perl.perl5.porters |
Postings from July 2016
Re: hv_bucket_ratio()
Thread Previous
|
Thread Next
From:
demerphq
Date:
July 7, 2016 13:08
Subject:
Re: hv_bucket_ratio()
Message ID:
CANgJU+US9COxdj=xhZLbb1iiNMMJHFaHxF1=tsOMGnPW-HyY=g@mail.gmail.com
Thanks Dave. Sorry for the inconvenience.
Yves
On 7 Jul 2016 04:47, "Dave Mitchell" <davem@iabyn.com> wrote:
> On Sun, Jul 03, 2016 at 11:19:59PM +0200, demerphq wrote:
> > On 30 Jun 2016 23:01, "Karl Williamson" <public@khwilliamson.com> wrote:
> > >
> > > Commit 8bf4c4010cc474d4000c2a8c78f6890fa5f1e577 added this function,
> but
> > marked it as deprecated. I suspect this is wrong, and it is not supposed
> > to be deprecated.
> >
> > Depends on your definition of wrong..
> >
> > It was deliberate but perhaps misguided...
> >
> > I wanted to express that the function was available but with no future
> > commitments at all, including removal.
> >
> > Feel free to change it to something more appropriate.
>
>
> I've just pushed this:
>
>
> commit 1164fd158dc892739cc9ec8b770081b2770c047f
> Author: David Mitchell <davem@iabyn.com>
> AuthorDate: Thu Jul 7 09:40:22 2016 +0100
>
> undeprecate hv_bucket_ratio()
>
> This function was recently added, but marked as deprecated in
> embed.fnc.
> Based on this thread:
>
> http://nntp.perl.org/group/perl.perl5.porters/237486
>
> It looks like the 'M' (may change) flag is sufficient to capture what
> was
> intended. Removing the 'D' avoids every usage in core emitting a
> warning
> to STDERR during build, while it still adds a caution to the entry in
> perlapi.pod:
>
> NOTE: this function is experimental and may change or be
> removed without notice.
>
>
> Affected files ...
> M embed.fnc
> M proto.h
>
> Differences ...
>
> diff --git a/embed.fnc b/embed.fnc
> index fe5eb68..88a70f9 100644
> --- a/embed.fnc
> +++ b/embed.fnc
> @@ -2774,7 +2774,7 @@ Apod |void |hv_assert |NN HV *hv
> #endif
>
> ApdR |SV* |hv_scalar |NN HV *hv
> -ApdRMD |SV* |hv_bucket_ratio|NN HV *hv
> +ApdRM |SV* |hv_bucket_ratio|NN HV *hv
> ApoR |I32* |hv_riter_p |NN HV *hv
> ApoR |HE** |hv_eiter_p |NN HV *hv
> Apo |void |hv_riter_set |NN HV *hv|I32 riter
>
>
>
> --
> "I do not resent criticism, even when, for the sake of emphasis,
> it parts for the time with reality".
> -- Winston Churchill, House of Commons, 22nd Jan 1941.
>
Thread Previous
|
Thread Next