develooper Front page | perl.perl5.porters | Postings from June 2016

Re: [PATCH] - fix for Coro (was Re: revert MG consting (Corobreakage) for 5.24?)

From:
Dave Mitchell
Date:
June 20, 2016 16:00
Subject:
Re: [PATCH] - fix for Coro (was Re: revert MG consting (Corobreakage) for 5.24?)
Message ID:
20160620160001.GI3289@iabyn.com
On Wed, May 04, 2016 at 03:29:58PM -0700, Father Chrysostomos wrote:
> I wrote:
> > Nicholas Clark wrote:
> > > I make the appended change to Coro.
> > > It builds.                           
> > 
> > In fact, if you redefine the PadlistNAMES macro in Coro, you should be
> > able to get it to work with 5.22 even without patching perl.
> 
> This patch works on an unpatched 5.22.0.

The following attached 5 patches, when applied to vanilla Coro 6.49,
makes it pass all tests under both perl 5.22.0 and 5.24.0.

I have Cc'ed Marc - it's in his hands now whether he wants to incorporate
them, but p5p's involvement in fixing Coro should be at an end now.

    0001-Coro-Nick-and-sprout-s-combined-5.22.0-fix.patch

        This is Nicholas's fix for the $SIG{__WARN__} and consted vtable
        issue, along with Sprout's PadlistNAMES() fix, as discussed
        in this thread.

    0002-fixup-to-SIG-magic-patch.patch
        This is my fixup to that path to fix a compiler warning.

    0003-Coro-handle-argarray-removal-in-5.23.8.patch
        This is my fix for the removal of the argarray context field in
        5.23.8.

    0004-Coro-fix-exit.patch
        This makes t/12_exit.t pass.

    0005-Coro-handle-PL_savestack_max-offset-for-5.23.8.patch
        This makes t/07_eval.t pass.


-- 
The Enterprise's efficient long-range scanners detect a temporal vortex
distortion in good time, allowing it to be safely avoided via a minor
course correction.
    -- Things That Never Happen in "Star Trek" #21



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About