On 05/14/2016 07:39 AM, Dave Mitchell wrote: > On Thu, May 12, 2016 at 10:34:42PM -0600, Karl Williamson wrote: >> With commit 5f81fa4069cb15ccd77b1c4253c870df84c1788a > > I don't see that commit id. commit 5f81fa4069cb15ccd77b1c4253c870df84c1788a *Merge: 52de5f3 fb24590 Author: Karl Williamson <khw@cpan.org> Date: Thu May 12 20:21:44 2016 -0600 * Merge branch to not require mathoms special cases into blead > >> moving something to >> mathoms.c is now simplified. > > Thanks for this. > >> To move a function to mathoms.c ... > > should these instructons also be put at the top of mathoms.c? Done. > >> If you don't know what mathoms is, >> >> /* >> * Anything that Hobbits had no immediate use for, but were unwilling to >> * throw away, they called a mathom. Their dwellings were apt to become >> * rather crowded with mathoms, and many of the presents that passed from >> * hand to hand were of that sort. >> * >> * [p.5 of _The Lord of the Rings_: "Prologue"] >> */ > > I've never been entirely clear what the *actual* point of mathoms.c is. > I had always assumed it was to allow binary compatibility: i.e. > when something is converted from a function to a macro, XS code that > had been compiled to use that function would still dynamically link > against a newer perl in the same series. I was just guessing, based on the comments I saw, and the fact that it doesn't get cleaned out. > > But if this is the case, I think we should be emptying out mathoms.c > just before every major release, which we don't appear to do. >Thread Previous | Thread Next