develooper Front page | perl.perl5.porters | Postings from May 2016

Re: 5.24.0 + cpan

Thread Previous | Thread Next
From:
Aaron Crane
Date:
May 16, 2016 19:38
Subject:
Re: 5.24.0 + cpan
Message ID:
CACmk_tsofE1XZ-Om0WBwWGxtcMzSDVJ1ZFBOhVHZ_xSEhjSX0A@mail.gmail.com
Zefram <zefram@fysh.org> wrote:
> H.Merijn Brand wrote:
>>This is much worse than I expected: the #! line kills all that have the
>>correct perl on it!
>>
>>$ cat test.pl
>>#!/opt/perl64/bin/perl
>
> Oh.  "perl6".  d9fc04eebe29b8cf5f6f6bf31373b202eafa44d6.

Assuming that we retain the behaviour of honouring "perl6" in a
shebang line, how about this change?

diff --git a/toke.c b/toke.c
index b16544b..8444321 100644
--- a/toke.c
+++ b/toke.c
@@ -5062,7 +5062,7 @@ Perl_yylex(pTHX)
                d = instr(s,"perl -");
                if (!d) {
                    d = instr(s,"perl");
-                    if (d && d[4] == '6')
+                    if (d && d[4] == '6' && !isdigit(d[5]))
                         d = NULL;
 #if defined(DOSISH)
                    /* avoid getting into infinite loops when shebang

(Also attached as a real patch.)

-- 
Aaron Crane ** http://aaroncrane.co.uk/

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About