develooper Front page | perl.perl5.porters | Postings from May 2016

[perl #126686] [PATCH] make_ext.pl: run all Makefile.PLes in 1process

From:
Tony Cook via RT
Date:
May 16, 2016 05:51
Subject:
[perl #126686] [PATCH] make_ext.pl: run all Makefile.PLes in 1process
Message ID:
rt-4.0.18-26665-1463377855-329.126686-15-0@perl.org
On Tue Dec 01 14:21:26 2015, bulk88 wrote:
> !Unicode/Normalize" to complete on Win32. This patch catches all exit() calls 
> from Makefile.PLs, including exit(0). While exit(0) is techincally legal for 
> Makefile.PLs to do, it is rare, nearly all Makefile.PLs fall off the end when 
> they are done. So exit(0) for core purposes is really an error since the
> build will prematurly stop. Fix the 1 case where exit(0) was called. This 
> patch also catches exceptions from the Makefile.PL. See Perl RT ticket for 
> details.

That's pretty questionable.

DB_File is CPAN upstream, I'm not sure it's worth breaking its Makefile.PL for a small build-time optimization.

There is a build time advantage on Linux - full make -j6 build time (not include Configure) on a 4 core CPU:

before:

real    1m16.346s
user    3m54.684s
sys     0m11.048s

real    1m13.703s
user    3m54.704s
sys     0m10.884s

real    1m10.914s
user    3m56.012s
sys     0m10.872s

after:

real    1m10.237s
user    3m56.036s
sys     0m10.676s

real    1m8.678s
user    3m54.780s
sys     0m11.132s

real    1m10.573s
user    3m55.748s
sys     0m10.868s

Tony

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=126686



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About