develooper Front page | perl.perl5.porters | Postings from May 2016

Re: revert MG consting (Coro breakage) for 5.24?

From:
Nicholas Clark
Date:
May 3, 2016 18:49
Subject:
Re: revert MG consting (Coro breakage) for 5.24?
Message ID:
20160503184022.GN2048@ceres.etla.org
On Tue, May 03, 2016 at 04:56:31PM +0100, Dave Mitchell wrote:
> Rik, 
> I hadn't realised until recently that the Coro breakage caused by
> consting the MGF vtable array in commit v5.21.7-98-gc910fea, is still
> unresolved.
> 
> I propose that we revert this commit for 5.24 (we need another RC anyway
> for the SvGROW) issue.

What does this gain?

Coro still won't compile against 5.24.x without other changes (due to your
context stack reworking), and still won't compile against 5.22.x (because this
wouldn't be backported).

> This should have relatively minimal effect (apart from 4K extra memory
> usage per process), since all it would be doing is removing a constraint
> on XS code (the vtable array can now be modified by XS code again).

So as best I can tell, all this achieves is a 4K increase in memory usage
per process. It doesn't fix Coro. What's the upside?

Nicholas Clark



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About