develooper Front page | perl.perl5.porters | Postings from January 2016

[perl #126847] fdclose(3) patch

From:
James E Keenan via RT
Date:
January 23, 2016 03:26
Subject:
[perl #126847] fdclose(3) patch
Message ID:
rt-4.0.18-28937-1453519587-231.126847-15-0@perl.org
On Mon Jan 04 14:27:06 2016, doughera wrote:
> On Sat, Jan 02, 2016 at 03:52:48PM +0100, Mariusz Zaborski wrote:
> > On Thu, Dec 31, 2015 at 11:44:10AM -0500, Andy Dougherty wrote:
> > > On Tue, Dec 15, 2015 at 06:01:15PM +0100, Mariusz Zaborski wrote:
> > > > Patch in attachment.
> > > > What do you thinks? 
> > > 
> > > Thank you for the patch.  I have attached two suggested patches which
> > > ought to have the equivalent functionality, but might be a bit
> > > more general.
> > > 
> > > The first simply uses fdclose() if it's available as the first line of
> > > attack in PerlIOStdio_invalidate_fileno.  I did not make it specific to
> > > FreeBSD in case other OSes also adopt this function.  The second (much
> > > longer) adds Configure support for the HAS_FDCLOSE symbol.  This is
> > > currently smoking in the smoke-me/andyd/fdclose branch.
> > > 
> > > I did note that a standard run of 'make test' never seems to call this 
> > > function, so I don't know how much it is actually used.
> > It's looking great for me!!!
> 
> Now pushed as 
>     8b8c6ab7a0f348f87b1d3cb71ad386b19d348719
> and
>     36b1c8929241ab83b3003de806e94e66990e4c6d
> 
> I have separately pushed the d_fdclose.U metaconfig unit to perl's
> metaconfig repository.
> 
> Let me know of any problems,
> 

No complaints in 18 days since patches were applied; marking ticket Resolved.

Thank you very much.

-- 
James E Keenan (jkeenan@cpan.org)

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=126847



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About