Front page | perl.perl5.porters |
Postings from December 2015
Am 18.12.2015 um 01:39 schrieb demerphq: > On 18 December 2015 at 00:14, Chad Granum <exodist7@gmail.com> wrote: >> new patch >> >> On Thu, Dec 17, 2015 at 2:57 PM, Chad Granum <exodist7@gmail.com> wrote: >>> >>> No sooner did I send that then I realize did could do it better with 1 >>> less loop. Will attach new patch shortly. > > I have one concern with the patch. It uses ref($foo) eq "HASH". > > I think it should import reftype() from Scalar::Util and use reftype() instead. > > Or possibly be switched to use UNIVERSAL::isa($foo,"HASH"). > > IOW, what happens if $foo is blessed? reftype is for deliberately breaking encapsulation of objects. I'd prefer if Exporter stringified objects or just didn't accept them. Let the user specify a plain hash if they want this feature. </bikeshed> -- Lukas Mai <plokinom@gmail.com>Thread Previous | Thread Next