develooper Front page | perl.perl5.porters | Postings from December 2015

Re: Cygwin cygdrive prefix (was: TONYC TPF Grant - October 2015)

Thread Previous | Thread Next
Tony Cook
December 4, 2015 23:44
Re: Cygwin cygdrive prefix (was: TONYC TPF Grant - October 2015)
Message ID:
On Fri, Dec 04, 2015 at 08:47:32PM +0100, Achim Gratz wrote:
> Tony Cook writes:
> >   1.15          cygwin build issue, test failure
> Sorry to piggy-back on here, but I didn't find where this was discussed
> on the list (if it was).

It wasn't, I saw it failing in smoke testing (which I run for cygwin),
and fixed it.

> >From the date of the commit I assume that 636efde is (at least in part)
> what's meant here.  I suggest that the fix should be cherry-picked to
> the 5.22.1 branch.
> To the fix itself, using df will eventually fail on some systems even
> with the "-a" switch since you can't assume that a C: drive exists.  A
> more appropriate way to obtain the cygdrive prefix is to use

It shouldn't fail, it should skip if there's no C: drive.

> readlink "/proc/cygdrive"
> or `readlink -f /proc/cygdrive` or maybe even `cygpath -u C:` (the
> latter works even if the drive in question doesn't exist and presumably
> does so even on older versions of Cygwin that didn't have the /proc
> pseudo-fs).

If you have a patch, I'd be happy to review and probably apply it if
you perlbug it.


Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About