develooper Front page | perl.perl5.porters | Postings from November 2015

[perl #126686] [PATCH] make_ext.pl: run all Makefile.PLes in 1process

From:
James E Keenan via RT
Date:
November 23, 2015 23:47
Subject:
[perl #126686] [PATCH] make_ext.pl: run all Makefile.PLes in 1process
Message ID:
rt-4.0.18-13580-1448322409-825.126686-15-0@perl.org
On Thu Nov 19 21:24:00 2015, bulk88 wrote:
> This is a bug report for perl from bulk88@hotmail.com,
> generated with the help of perlbug 1.40 running under perl 5.23.5.
> 
> 
> -----------------------------------------------------------------
> [Please describe your issue here]
> 
> 
> ..\miniperl.exe -I..\lib ..\make_ext.pl "MAKE=dmake" --dir=..\cpan
> --dir=..\dist --dir=..\ext --dynamic !Unicode/Normalize
> 

The patch, which touches only one file, is over 500 lines along -- but my quick scan of it suggests that many of the changes are whitespace only.  That makes it more difficult to review.

Would it be possible to re-draw the patch against blead without making any whitespace changes?

(I'm not opposed to tidying the code, but because the file being revised is not well known, I'd like to get discussion of the changes going before worrying about tidying.)

Thank you very much.


-- 
James E Keenan (jkeenan@cpan.org)

---
via perlbug:  queue: perl5 status: new
https://rt.perl.org/Ticket/Display.html?id=126686



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About