Re: warning (sermon?) about strcat() from openbsd linker

On Fri, Oct 16, 2015 at 08:51:44PM -0400, Jarkko Hietaniemi wrote:
> cc -o perl -Wl,-E  -fstack-protector -L/usr/local/lib  perlmain.o 
> libperl.a `cat ext.libs` -lpthread -lm -lutil -lc
> libperl.a(DynaLoader.o)(.text+0x729): In function 
> `XS_DynaLoader_dl_load_file':
> : warning: strcat() is almost always misused, please use strlcat()
> 
> $ uname -a
> OpenBSD openbsd 4.9 GENERIC#671 i386
> $ cc -v
> Reading specs from 
> /usr/bin/../lib/gcc-lib/i386-unknown-openbsd4.9/4.2.1/specs
> Target: i386-unknown-openbsd4.9
> Configured with: OpenBSD/i386 system compiler
> Thread model: posix
> gcc version 4.2.1 20070719

I don't agree with it totally. I replaced 2 strcat()s with 1 strlen() and
1 memcpy() in commit 00ebc5bdc54d3943d2470f1053942f5849ab1a9d

Nicholas Clark

• warning (sermon?) about strcat() from openbsd linker by Jarkko Hietaniemi
• Re: warning (sermon?) about strcat() from openbsd linker by Zefram
• Re: warning (sermon?) about strcat() from openbsd linker by Craig A. Berry
• Re: warning (sermon?) about strcat() from openbsd linker by Nicholas Clark