develooper Front page | perl.perl5.porters | Postings from June 2015

[perl #125429] [PATCH] Convert "\t"s to spaces in perlmod.pod

Thread Next
From:
Tony Cook via RT
Date:
June 22, 2015 23:18
Subject:
[perl #125429] [PATCH] Convert "\t"s to spaces in perlmod.pod
Message ID:
rt-4.0.18-31971-1435015113-418.125429-15-0@perl.org
On Mon Jun 22 15:49:28 2015, jkeenan wrote:
> On Wed Jun 17 06:20:17 2015, shlomif@shlomifish.org wrote:
> > The attached patch converts "\t"s to spaces in perlmod.pod for
> > consistency and
> > for getting rid of some variations in the presentation. Please
> > consider
> > applying it. It also can be found here:
> >
> > https://github.com/shlomif/perl5/tree/perlmod-tabs-to-spaces
> >
> 
> > -- Shlomi Fish
> 
> Shlomi, with respect to this ticket and RT #124530, please supply the
> patches as attachments to this RT (or to email sent to perlbug)
> created with 'git-format-patch'.
> 
> In pod/perlhack.pod we ask that patch submissions be done this way so
> we can keep track of all the patches we get, and so we can review them
> all the same way.  You've done this before, so you know the drill.

The attachments on both tickets look like format-patch patches to me, and git am certainly applies the patch attached to this ticket for me.

If you're seeing a >From as the first line, you might be running into a problem mail clients can have with mbox storage, extracting the patches from the RT web UI, or editing out the > should allow the patch to apply correctly.

As to whether these patches should be applied, in general we don't do mass whitespace conversion, since it complicates rebasing and backporting patches, and makes blame a bit more annoying.

So I don't think these should be applied.

Tony

---
via perlbug:  queue: perl5 status: stalled
https://rt.perl.org/Ticket/Display.html?id=125429

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About