develooper Front page | perl.perl5.porters | Postings from May 2015

Re: 5.22 breaks Coro-6.42

Thread Previous | Thread Next
From:
Max Maischein
Date:
May 31, 2015 15:34
Subject:
Re: 5.22 breaks Coro-6.42
Message ID:
556B29E8.4070106@corion.net
I did some spelunking in git history and some comparing between 5.20 and 
5.22-RC2, and here are my findings (as on irc):

There are two errors. One can be easily fixed by reverting the patch 
c910fead7893fe9700031ee59de6b904260b5d69 :

State.xs:3472:9: error: assignment of member 'svt_get' in read-only object
          orig_sigelem_get = PL_vtbl_sigelem.svt_get; 
PL_vtbl_sigelem.svt_get
  = coro_sigelem_get;
          ^
State.xs:3473:9: error: assignment of member 'svt_set' in read-only object
          orig_sigelem_set = PL_vtbl_sigelem.svt_set; 
PL_vtbl_sigelem.svt_set
  = coro_sigelem_set;
          ^
State.xs:3474:9: error: assignment of member 'svt_clear' in read-only object
          orig_sigelem_clr = PL_vtbl_sigelem.svt_clear; 
PL_vtbl_sigelem.svt_clear
  = coro_sigelem_clr;
          ^

The second error, I don't understand or what is the real cause:

State.xs:558:29: error: lvalue required as left operand of assignment
    PadlistNAMES (newpadlist) = (PADNAMELIST *)SvREFCNT_inc_NN 
(PadlistNAMES (padlist));

This one was likely introduced by 
9b7476d7a269a4d9bb24393ae5c8d75efe2fcab4 , but that one doesn't revert 
easily.

-max

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About