develooper Front page | perl.perl5.porters | Postings from May 2015

Re: [perl #123998] blead's EUMM always fails tests on Win32 Perl onWin64

Thread Previous | Thread Next
Dave Mitchell
May 12, 2015 16:41
Re: [perl #123998] blead's EUMM always fails tests on Win32 Perl onWin64
Message ID:
On Sun, May 10, 2015 at 05:21:09PM -0700, Tony Cook via RT wrote:
> On Fri May 08 16:57:16 2015, bulk88 wrote:
> > I did that in the attached patch. t/porting/utils.t also needs git in
> > %PATH% to fail on win32, since if there is no working git, the whole
> > file is skipped, and I dont always keep git in my %PATH% on win32.
> > 
> > I dont personally like the idea of sending the error to null and I
> > dont like the patch I wrote, since whatever info ("active code page")
> > is collected will be wrong with no warning for EUMM users. IDK enough
> > to say if having the wrong infp makes a difference in the end or not.
> With your patch it will fallback to the default, cp1252.
> For blead's purposes, sufficiently recent releases of include
> GetACP(), GetConsoleCP() and GetConsoleOutputCP() which means blead could
> skip calling chcp completely.

I've pushed Daniel's patch for smoking as
(with a more detailed commit message) This seems about the least invasive
change at this late stage.
I've bumped ExtUtils::MakeMaker::Locale's version from 7.04 7.04_01.
Is that the right thing to do? Are there any other files that need
touching to indicate this customisation? I've rather lost touch with the
state of play on this sort of thing. I guess Porting/
CUSTOMIZED field?? And t/porting/customized.dat???

More than any other time in history, mankind faces a crossroads. One path
leads to despair and utter hopelessness. The other, to total extinction.
Let us pray we have the wisdom to choose correctly.
    -- Woody Allen

Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About