develooper Front page | perl.perl5.porters | Postings from May 2015

[perl #124364] Some version strings in %Module::CoreList::delta contain trailing space and cause warning with version->parse

Thread Previous | Thread Next
From:
Yary via RT
Date:
May 3, 2015 04:18
Subject:
[perl #124364] Some version strings in %Module::CoreList::delta contain trailing space and cause warning with version->parse
Message ID:
rt-4.0.18-13532-1430593531-1828.124364-15-0@perl.org
> > These versions with spaces are an accurate representation of what the
> > versions were defined as.  As an example, in perl 5.006,
> > lib/ExtUtils/MM_Unix.pm, line 11:
> >
> > $VERSION = substr q$Revision: 1.12603 $, 10;
> >
> > This leaves a trailing space.
> >
> 
> I would consider that an unhelpful artifact. Historically correct as it may
> be, leaving it in only causes headaches and doesn't solve any problem I can
> imagine.

The "version.pm" docs say that the above looks like a CVS revision, and "CVS $Revision$ increments differently from Decimal versions (i.e. 1.10 follows 1.9), so it must be handled as if it were a Dotted-Decimal Version" like "v1.12603"

which leads me to believe that a large number of version strings in Module::CoreList should have a leading "v" on them so they will compare correctly. For example 'Module::Pluggable' is at version '3.8', if it were to go to '3.10' then this would be a problem, whereas 'v3.10' would compare properly against 'v3.8'.

On the other hand, when I look at the actual version numbers, the authors seem to be sane about this.

That's beyond what I can do in today's Hackathon, but I will have a smaller pull request by the end of the day. It will also handle "CGI::Fast" which has a letter in its version "1.00a", and letters are just plain wrong, according to version.pm. Full comments will be in the pull request.

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=124364

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About