develooper Front page | perl.perl5.porters | Postings from April 2015

[perl #124420] [PATCH] $Carp::MaxArgNums off-by-one error

Thread Previous | Thread Next
From:
Alexander D'Archangel via RT
Date:
April 30, 2015 04:20
Subject:
[perl #124420] [PATCH] $Carp::MaxArgNums off-by-one error
Message ID:
rt-4.0.18-14762-1430367593-1563.124420-15-0@perl.org
On Wed Apr 29 17:46:34 2015, jkeenan wrote:
> I created a branch from blead and applied your patch.  I then ran
> 'make test' as I customarily do.
> 
> I got two failures related to your patch.  One failure detected the
> fact that while you incremented the version number in Carp.pm, you did
> not do so in Carp/Heavy.pm.  That was easily fixed.
> 
> But the other failures were in dist/Carp/t/Carp.t and were more
> extensive.  I'm attaching the output.  We cannot proceed with failures
> like these.
> 
> Thank you very much.

Thank you very much for your attention.  I'm not sure how I missed the failure in heavy.t; it happens here, too, and I have updated the proposed patch to address that failure.  Sorry for that mistake.

I'm a little confused by the other failure messages you got, though.  The failures you forwarded me are the ones that test the new behavior.  This error is exactly what I would expect to see if one were to run the new tests against the old version of the library.  I can't reproduce them; make test with my patch applied to 996de84d864e2452987ceb29dbf56f1ce92846b8 comes back clean.  I've attached an updated patch that fixes the heavy.t failure and also makes the failure messages you got less hideous.

Thank you,

D'A

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=124420

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About