develooper Front page | perl.perl5.porters | Postings from April 2015

[perl #124364] Some version strings in %Module::CoreList::delta contain trailing space and cause warning with version->parse

Thread Previous
From:
James E Keenan via RT
Date:
April 26, 2015 13:02
Subject:
[perl #124364] Some version strings in %Module::CoreList::delta contain trailing space and cause warning with version->parse
Message ID:
rt-4.0.18-23093-1430053319-1726.124364-15-0@perl.org
On Thu Apr 23 21:45:43 2015, perlancar@gmail.com wrote:
> I'd love to get it integrated, but we should probably get at least a
> couple
> of other people looking at the code first to check its correctness
> first.
> 
> On Thu, Apr 23, 2015 at 7:24 PM, Ricardo Signes via RT <
> perlbug-followup@perl.org> wrote:
> 
> > * perlancar <perlbug-followup@perl.org> [2015-04-23T02:15:31]
> > > Some version strings in %Module::CoreList::delta contain trailing
> > > space
> > and
> > > cause warning with version->parse, e.g. there is one '1.15 ' which
> > > when
> > fed
> > > to version->parse under warnings:
> > >
> > > % perl -wE'say version->parse("1.15 ")'
> > > Version string '1.15 ' contains invalid data; ignoring: ' ' at -e
> > > line
> > 1.
> > > 1.15
> >
> > Thanks, I believe I have just fixed all this with b7c1f08.
> >
> > I see that you probably found this while working on
> > Module::CoreList::More,
> > which contains, among other things, a "faster is_core."  Is there a
> > reason
> > we
> > shouldn't use your implementation in Module::CoreList?
> >
> > It seems a shame to leave it in an add-on module that many users
> > would
> > never
> > see.
> >
> > --
> > rjbs
> >
> >

I've created a project to evaluate Module-CoreList-More at the New York Perl Hackathon, coming up on May 2.

https://github.com/nyperlmongers/nyperlhackathon2015/wiki/Evaluate-Module-CoreList-More

So perhaps we'll get some eyeballs on this there.

Thank you very much.


-- 
James E Keenan (jkeenan@cpan.org)

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=124364

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About