Re: [perl #124364] Some version strings in %Module::CoreList::deltacontain trailing space and cause warning with version->parse

I'd love to get it integrated, but we should probably get at least a couple
of other people looking at the code first to check its correctness first.

On Thu, Apr 23, 2015 at 7:24 PM, Ricardo Signes via RT <
perlbug-followup@perl.org> wrote:

> * perlancar <perlbug-followup@perl.org> [2015-04-23T02:15:31]
> > Some version strings in %Module::CoreList::delta contain trailing space
> and
> > cause warning with version->parse, e.g. there is one '1.15 ' which when
> fed
> > to version->parse under warnings:
> >
> >  % perl -wE'say version->parse("1.15 ")'
> >  Version string '1.15 ' contains invalid data; ignoring: ' ' at -e line
> 1.
> >  1.15
>
> Thanks, I believe I have just fixed all this with b7c1f08.
>
> I see that you probably found this while working on Module::CoreList::More,
> which contains, among other things, a "faster is_core."  Is there a reason
> we
> shouldn't use your implementation in Module::CoreList?
>
> It seems a shame to leave it in an add-on module that many users would
> never
> see.
>
> --
> rjbs
>
>

• [perl #124364] Some version strings in %Module::CoreList::delta contain trailing space and cause warning with version->parse by Graham Knop via RT
• Re: [perl #124364] Some version strings in %Module::CoreList::deltacontain trailing space and cause warning with version->parse by Leon Timmermans
• [perl #124364] Some version strings in %Module::CoreList::delta contain trailing space and cause warning with version->parse by Yary via RT
• [perl #124364] Some version strings in %Module::CoreList::delta contain trailing space and cause warning with version->parse by Yary via RT
• [perl #124364] Some version strings in %Module::CoreList::delta contain trailing space and cause warning with version->parse by perlancar
• Re: [perl #124364] Some version strings in %Module::CoreList::deltacontain trailing space and cause warning with version->parse by Ricardo Signes
• Re: [perl #124364] Some version strings in %Module::CoreList::deltacontain trailing space and cause warning with version->parse by Perl Ancar
• [perl #124364] Some version strings in %Module::CoreList::delta contain trailing space and cause warning with version->parse by James E Keenan via RT