develooper Front page | perl.perl5.porters | Postings from February 2015

[perl #123814] grok_atou() for regexp quantifiers

Thread Previous | Thread Next
Hugo van der Sanden via RT
February 20, 2015 15:52
[perl #123814] grok_atou() for regexp quantifiers
Message ID:
On Fri Feb 20 05:39:45 2015, jhi wrote:
> On Thursday-201502-19 11:30, Hugo van der Sanden via RT wrote:
> > I've repushed branch hv/grok with a second commit as a proof of
> > concept.

I should mention also that I'd planned to add type-specific variants for eg U32, I32 etc afterwards, but I'm less convinced now that they would add significant value. I'm hoping that if all the examples in core look like 'if (grok_atoUV(...) && uv <= SOME_LIMIT)' people will copy and adapt that appropriately.

> >  There's a few loose ends, but should be enough to see how
> > much you like or hate it - passes a basic test run except for XS-
> > APItest, for which I'll need to acquire some XS fu.
> Looks good, thanks!
> In the APItest.xs I am not certain what was the problem, but I think
> you just need to rename the numeric.xs:grok_atou() as grok_atoUV(),
> and change it to call grok_atoUV() properly?

Merely lack of experience with XS; once I found an example elsewhere of returning a boolean it was straightforward.

> There's also Devel::PPPort code which deals with grok_atou().
> We don't need backward compat code for it since it has been in
> only 5.21.*

As far as I can see, the only reference is the captured embed.fnc entry, it's on the unsupported list; I assume after this lands, the next update to PPPort will magically remove grok_atou and add grok_atoUV - Matthew, is that correct?

There are also some references in perlclib.pod, which will need some new text since we no longer have a drop-in substitute, and the XXX comments for (at least) magic_set() and reg() need some thinking.

I think what's there now is worth some smoke-testing, I've renamed the branch to smoke-me/hv-grok.


via perlbug:  queue: perl5 status: open

Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About