develooper Front page | perl.perl5.porters | Postings from February 2015

Re: [perl #123814] grok_atou() for regexp quantifiers

Thread Previous | Thread Next
From:
demerphq
Date:
February 19, 2015 15:10
Subject:
Re: [perl #123814] grok_atou() for regexp quantifiers
Message ID:
CANgJU+WoYVwBD=ZeUMuU+HmWL9bP2Ch7gScMdzQH6BELn3Tk4g@mail.gmail.com
On 19 February 2015 at 22:33, Jarkko Hietaniemi via RT
<perlbug-followup@perl.org> wrote:
> To the tune of "everybody should take out their own garbage", attached is a patch that would remove grok_atou(), and leave the atoi() (and strtol, etc.) in their naked glory.  But this state of things does not pass e.g. the tests added in
>
>     [perl #123782] regcomp: check for overflow on /(?123)/
>
> aka http://perl5.git.perl.org/perl.git/commit/b3725d49f914ef2bed63d7eb92a72ef6e886b489
>
> But one can take a look at the patch to see where the atoi() spots are.

My inclination is to go with Hugo's option. I dont think reverting
this stuff is ideal. But i think at this point it is up to Hugo.

cheers,
Yves

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About