develooper Front page | perl.perl5.porters | Postings from February 2015

[perl #123620] [PATCH] introduce PL_w32_osver

Thread Previous
From:
Tony Cook via RT
Date:
February 3, 2015 01:20
Subject:
[perl #123620] [PATCH] introduce PL_w32_osver
Message ID:
rt-4.0.18-21243-1422926417-978.123620-15-0@perl.org
On Mon Jan 26 21:30:48 2015, bulk88 wrote:
> On Mon Jan 26 19:50:09 2015, tonyc wrote:
> > On Sat Jan 17 23:11:42 2015, bulk88 wrote:
> > > This patch has POD problems I haven't been able to solve.
> > 
> > There is no patch.
> > 
> > Tony
> 
> attached

Thanks.

I'd like to see comments from jdb on this.

I can see this (very slightly) slowing down calls into Win32::* functions that use the version structure, since rather than using the module global g_osver, they need to look up the perl defined structure in the import table and then use that pointer to fetch the value.

Any gain in space/time from moving the only r/w static storage out of Win32.xs could be lost easily if a new static variable was added.

Wouldn't:

#if !((PERL_VERSION >= 5) && (PERL_VERSION >= 21) && (PERL_SUBVERSION >= 8))

be simpler as just:

#if !defined(dW32OSVER)

?

Tony


---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=123620

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About