[perl #123633] [PATCH] factor out an %ENV assignment from make_ext.pl

On Mon Jan 26 19:10:35 2015, jkeenan wrote:
> On Mon Jan 19 23:48:49 2015, bulk88 wrote:
> > This is a bug report for perl from bulk88@hotmail.com,
> > generated with the help of perlbug 1.40 running under perl 5.21.4.
> > 
> > 
> > -----------------------------------------------------------------
> > [Please describe your issue here]
> > 
> > See attached patch. Half a ms savings is very low, but it was the 
> > easiest thing to improve. For make_ext.pl, outside of system()/``, 
> > regexps are the next biggest class of time, the file test operators come 
> > after that. ("-d" is 4 Win32 kernel calls (opendir/FindFirstFile 
> > readdir/FindNextFile  close/CloseHandle stat/GetFileAttributes) instead 
> > of 1 kernel call(stat/GetFileAttributes).
> > 
> 
> Can you provide the exact perl program you used with Devel::NYTProf?
> 
> Thank you very much.
> 

C:\perl521\src\win32>C:\perl521\bin\perl.exe -d:NYTProf -I..\lib ..\make_ext.pl "MAKE=nmake -nologo" --dir=..\cpan --dir=..\dist --dir=..\ext --dynamic

I didn't fake the no dynaloader scenario of miniperl, but I wasn't interested in the performance of anything but the file make_ext.pl. EUMM on win32 shells out instead of using XS modules in a couple places with miniperl for example.


-- 
bulk88 ~ bulk88 at hotmail.com

---
via perlbug:  queue: perl5 status: open
https://rt.perl.org/Ticket/Display.html?id=123633

• [perl #123633] [PATCH] factor out an %ENV assignment from make_ext.pl by bulk88 via RT
• [perl #123633] [PATCH] factor out an %ENV assignment from make_ext.pl by James E Keenan via RT