develooper Front page | perl.perl5.porters | Postings from January 2015

Re: [perl #123616] Weed out needless PERL_UNUSED_ARG

Thread Previous | Thread Next
From:
hv
Date:
January 18, 2015 01:26
Subject:
Re: [perl #123616] Weed out needless PERL_UNUSED_ARG
Message ID:
201501180126.t0I1QPP00885@crypt.org
bulk88 <bulk88@hotmail.com> wrote:
:hv@crypt.org wrote:
:> "bulk88 via RT" <perlbug-followup@perl.org> wrote:
:> :Im inclined to say https://rt.perl.org/Ticket/Attachment/1326848/707965/0001-Removed-PERL_UNUSED_ARG-in-S_grok_bslash_x.patch is wrong. output_warning is unused in non-DEBUGGING and DEBUGGING. I removed it as an experiment and both build types compiled, see attached patch.
:> 
:> How is that managing to compile line 226, just after the context lines
:> in the patch:
:>     if (strict || ! output_warning) {
:> ?
:> 
:> Hugo
:
:
:My patch worked on blead from Jan 6 2015/ 
:735ecbe919d740c2d0068de6daf6f2359bbcd3eb  :(
:
:var output_warning really was unused on that day

Ah, the reference was newly added by khw in 879eb60498 a week ago:
    Output warning in qr// only once

Hugo

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About