develooper Front page | perl.perl5.porters | Postings from January 2015

[perl #123616] Weed out needless PERL_UNUSED_ARG

Thread Next
bulk88 via RT
January 17, 2015 22:57
[perl #123616] Weed out needless PERL_UNUSED_ARG
Message ID:
On Sat Jan 17 09:00:57 2015, wrote:
> Hi there,
> This is my first time contributing a patch so I'm looking for a little
> guidance. As suggested by the subject and with assistance from Hugo at
> the London Perl Hackday, I've weeded out some obvious PERL_UNUSED_ARG
> statements inside static functions as requested in the Perl 5 todo.pod
> file.
> The remaining PERL_UNUSED_ARG statements appear to be for variables
> that are (1) contained in non-static functions, (2) conditionally used
> depending on pre-processor macros  or (3) placeholders so that the
> static function prototypes match particular function pointers.
> I'm not sure if this task is completed yet so I haven't removed the
> item from yet. Let me know what you think. Thanks!
> Kind regards,
> Jasmine Ngan

Im inclined to say is wrong. output_warning is unused in non-DEBUGGING and DEBUGGING. I removed it as an experiment and both build types compiled, see attached patch.

bulk88 ~ bulk88 at

via perlbug:  queue: perl5 status: open

Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About