Front page | perl.perl5.porters |
Postings from January 2015
On Sat Jan 17 09:00:57 2015, jasmine.ngan@outlook.com wrote: > Hi there, > > This is my first time contributing a patch so I'm looking for a little > guidance. As suggested by the subject and with assistance from Hugo at > the London Perl Hackday, I've weeded out some obvious PERL_UNUSED_ARG > statements inside static functions as requested in the Perl 5 todo.pod > file. > > The remaining PERL_UNUSED_ARG statements appear to be for variables > that are (1) contained in non-static functions, (2) conditionally used > depending on pre-processor macros or (3) placeholders so that the > static function prototypes match particular function pointers. > > I'm not sure if this task is completed yet so I haven't removed the > item from todo.pm yet. Let me know what you think. Thanks! > > > Kind regards, > Jasmine Ngan > > Im inclined to say https://rt.perl.org/Ticket/Attachment/1326848/707965/0001-Removed-PERL_UNUSED_ARG-in-S_grok_bslash_x.patch is wrong. output_warning is unused in non-DEBUGGING and DEBUGGING. I removed it as an experiment and both build types compiled, see attached patch. -- bulk88 ~ bulk88 at hotmail.com --- via perlbug: queue: perl5 status: open https://rt.perl.org/Ticket/Display.html?id=123616Thread Next