develooper Front page | perl.perl5.porters | Postings from December 2014

Re: more smoker constipation?

Thread Previous | Thread Next
From:
hv
Date:
December 20, 2014 12:58
Subject:
Re: more smoker constipation?
Message ID:
201412201129.sBKBT2u28411@crypt.org
Earlier I wrote:
[...]
:For db58a81, as far as I can see the only use we make of RExC_naughty
:is here:
:
:    if (RExC_naughty >= 10)     /* Probably an expensive pattern. */
:
:.. so infinity is probably 10 in this case. We should probably define it
:that way, and change these checks to the simpler:
:
:                if (RExC_naughty < VERY_NAUGHTY)
:                    RExC_naughty += 2 + RExC_naughty / 2;
:
:.. with a compile-time assert somewhere that VERY_NAUGHTY < I32_MAX / 2 - 4,
:else we'll still have subtler overflows from all the ++ and +=4 scattered
:around.

I've now pushed 99807a43 'protect RExC_naughty changes behind macros' for
this, which also tries to add some explanation of how this is used.

Hugo
Thread Previous | Thread Next

nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About