Front page | perl.perl5.porters |
Postings from December 2014
On Fri, Dec 19, 2014 at 11:07:57PM +0000, Dave Mitchell wrote:
> With these commits, it now passes all tests (but with zillions of run-time
> warnings still):
>
> db58a81 fix integer overflow in S_regpiece().
> a1b2073 fix integer overflow in S_study_chunk().
> 55b6a5f fix integer overflow in S_study_chunk().
> 646e8787 fix integer overflow in S_scan_commit().
Yves/Hugo, could you review these commits? I have very little
understanding of the regex compiler, and "fixed" those issues based on the
vague notion that SSize_MAX probably represents infinity, and thus don't
add to it if we're already there. But I had no detailed understanding
of what each bit of code was doing and what the variables represent.
And in particular, I had no clue as to whether it was possible to come
up with test cases that demonstrate the issues.
--
Modern art:
"That's easy, I could have done that!"
"Ah, but you didn't!"
Thread Previous
|
Thread Next